fermosan commented on PR #6550: URL: https://github.com/apache/cloudstack/pull/6550#issuecomment-1283695723
> @fermosan did you answer all @rohityadavcloud 's comments? (i.e. do you guys agree this is ready or not?) @DaanHoogland @rohityadavcloud. There are two pending comments regarding NPEs for minCores and minMemory. I did not implemented them, they were there. I haven't looked all the code to determine if those values can ever be undefined. We redeployed all the code (with current branch and fixes) to a new environment and run all tests again. Everything was found in good order. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
