StepBee commented on issue #6807: URL: https://github.com/apache/cloudstack/issues/6807#issuecomment-1289053466
Looking at the code, i found [https://github.com/apache/cloudstack/blob/13d22c2f542b3570b190bf2eb2acfffae99ef528/plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java#L4762](url) which writes ~~~ private void setCpuTopology(CpuModeDef cmd, int vcpus, Map<String, String> details) { if (!enableManuallySettingCpuTopologyOnKvmVm) { s_logger.debug(String.format("Skipping manually setting CPU topology on VM's XML due to it is disabled in agent.properties {\"property\": \"%s\", \"value\": %s}.", AgentProperties.ENABLE_MANUALLY_SETTING_CPU_TOPOLOGY_ON_KVM_VM.getName(), enableManuallySettingCpuTopologyOnKvmVm)); return; } ~~~ which i think is then used in [https://github.com/apache/cloudstack/blob/13d22c2f542b3570b190bf2eb2acfffae99ef528/plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java#L1599](url) and results in xml generation, which we are looking for: [https://github.com/apache/cloudstack/blob/13d22c2f542b3570b190bf2eb2acfffae99ef528/plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java#L1631](url) ~~~ // add topology if (_sockets > 0 && _coresPerSocket > 0) { modeBuilder.append("<topology sockets='" + _sockets + "' cores='" + _coresPerSocket + "' threads='1' />"); } ~~~ So far, we have never been using `enable.manually.setting.cpu.topology.on.kvm.vm=true` but i will give it a try. Which still would not explain why the cpu topology is set on fixed offerings, but not on custom offerings. I'll update with the result. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
