shwstppr commented on code in PR #6851:
URL: https://github.com/apache/cloudstack/pull/6851#discussion_r1005837097


##########
server/src/main/java/com/cloud/api/query/QueryManagerImpl.java:
##########
@@ -1035,16 +1045,14 @@ private Pair<List<UserVmJoinVO>, Integer> 
searchForUserVMsInternal(ListVMsCmd cm
         Object backupOfferingId = cmd.getBackupOfferingId();
         Object isHaEnabled = cmd.getHaEnabled();
         Object pod = null;
-        Long clusterId = null;
+        Object clusterId = null;
         Object hostId = null;
         Object storageId = null;
         if (_accountMgr.isRootAdmin(caller.getId())) {
-            if (cmd instanceof ListVMsCmdByAdmin) {

Review Comment:
   `ListVMsMetricsCmd` is accessible to all users therefore new `ByAdmin` class 
added and new params not added in the original



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to