stephankruggg commented on code in PR #6898:
URL: https://github.com/apache/cloudstack/pull/6898#discussion_r1023392033
##########
api/src/main/java/org/apache/cloudstack/api/response/LBStickinessPolicyResponse.java:
##########
@@ -55,8 +55,8 @@ public class LBStickinessPolicyResponse extends BaseResponse {
@Param(description = "is policy for display to the regular user", since =
"4.4", authorized = {RoleType.Admin})
private Boolean forDisplay;
- // FIXME : if prams with the same name exists more then once then value
are concatinated with ":" as delimiter .
- // Reason: Map does not support duplicate keys, need to look for the
alernate data structure
+ // FIXME : if prams with the same name exists more then once then value
are concatenated with ":" as delimiter .
Review Comment:
```suggestion
// FIXME : if params with the same name exist more than once then values
are concatenated with ":" as delimiter .
```
##########
api/src/main/java/org/apache/cloudstack/api/command/admin/network/CreateStorageNetworkIpRangeCmd.java:
##########
@@ -64,7 +64,7 @@ public class CreateStorageNetworkIpRangeCmd extends
BaseAsyncCmd {
@Parameter(name = ApiConstants.VLAN,
type = CommandType.INTEGER,
- description = "Optional. The vlan the ip range sits on, default
to Null when it is not specified which means you network is not on any Vlan.
This is mainly for Vmware as other hypervisors can directly reterive bridge
from pyhsical network traffic type table")
+ description = "Optional. The vlan the ip range sits on, default
to Null when it is not specified which means you network is not on any Vlan.
This is mainly for Vmware as other hypervisors can directly retrieve bridge
from physical network traffic type table")
Review Comment:
```suggestion
description = "Optional. The vlan the ip range sits on,
default to Null when it is not specified which means your network is not on any
Vlan. This is mainly for Vmware as other hypervisors can directly retrieve
bridge from physical network traffic type table")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
