weizhouapache commented on code in PR #6919:
URL: https://github.com/apache/cloudstack/pull/6919#discussion_r1032116495
##########
server/src/main/java/org/apache/cloudstack/consoleproxy/ConsoleAccessManagerImpl.java:
##########
@@ -207,15 +199,22 @@ private ConsoleEndpoint generateAccessEndpoint(Long vmId,
String sessionUuid, St
throw new CloudRuntimeException(msg);
}
+ String vmUuid = vm.getUuid();
+ if (vm.getState() != VirtualMachine.State.Running) {
Review Comment:
@nvazquez
I think so.
the console icon is previously displayed for Starting/Stopping/Migrating VMs
on UI.(I do not know the current behavior)
for Stopping/Migrating VMs, console works mostly (please notice the
Migrating vm is running on the last host, not current host)
for Starting VMs, sometimes console works, sometimes console does not work
(depend on the VM state on hypervisor).
You can test with 4.17
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
