rohityadavcloud commented on code in PR #6956:
URL: https://github.com/apache/cloudstack/pull/6956#discussion_r1044140691
##########
ui/package.json:
##########
@@ -89,7 +89,6 @@
"eslint-plugin-vue": "^7.0.0",
"less": "^3.0.4",
"less-loader": "^5.0.0",
- "node-sass": "^4.0.0",
Review Comment:
cc @shwstppr @davidjumani @utchoang - pl check if we need node-sass?
Removing this unblocks us to use any node version (I've tested both node v16
and v18). I did some quick build and run checks and I don't see any issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
