weizhouapache commented on code in PR #6899:
URL: https://github.com/apache/cloudstack/pull/6899#discussion_r1048559943
##########
server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java:
##########
@@ -1135,6 +1145,8 @@ private String validateConfigurationValue(final String
name, String value, final
return errMsg;
}
+ isValueDeltaOrAll(name, value);
Review Comment:
@CharlesQueiroz
can you rename the method to indicate what the value is ?
##########
server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java:
##########
@@ -44,7 +44,7 @@
import javax.inject.Inject;
import javax.naming.ConfigurationException;
-
+import com.googlecode.ipv6.IPv6Network;
Review Comment:
@CharlesQueiroz
you remove the import from line 288 and import in line 47.
it is better to import it in line 288
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
