slavkap commented on code in PR #6661:
URL: https://github.com/apache/cloudstack/pull/6661#discussion_r1054055512
##########
plugins/storage/volume/storpool/src/main/java/org/apache/cloudstack/storage/datastore/provider/StorPoolHostListener.java:
##########
@@ -164,10 +163,25 @@ public boolean hostConnect(long hostId, long poolId)
throws StorageConflictExcep
StorPoolHelper.setSpClusterIdIfNeeded(hostId,
mspAnswer.getClusterId(), clusterDao, hostDao, clusterDetailsDao);
- log.info("Connection established between storage pool " + pool + " and
host " + hostId);
+ StorPoolUtil.spLog("Connection established between storage pool [%s]
and host [%s]", poolVO.getName(), host.getName());
return true;
}
+ private boolean isStorPoolVolumeOrStorageNotExistsOnHost(final Answer
answer) {
+ return answer.getDetails().equals("objectDoesNotExist") ||
answer.getDetails().equals("spNotFound");
Review Comment:
thanks @GutoVeronezi, for the review! @DaanHoogland, I will apply those
suggestions, but I'm on vacation and I have to fix my lab first. I will try to
apply them later today
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
