weizhouapache opened a new pull request, #7063:
URL: https://github.com/apache/cloudstack/pull/7063
### Description
This PR fixes #6740
The deleted service offering is not removed , but changed to Inactive state.
Therefore the state needs to be checked when deploy/create new vm or upgrade
vm.
Similar check is added to router service offering as well.
<!--- Describe your changes in DETAIL - And how has behaviour functionally
changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to
reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be
closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!---
*********************************************************************************
-->
<!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE
DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!---
*********************************************************************************
-->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to
-->
<!-- see how your change affects other areas of the code, etc. -->
```
(localcloud) 🐱 > deploy virtualmachine
zoneid=7c9769a1-ba70-4f3a-a976-5a6ae7d946bb
templateid=936f5eda-6be2-11ed-a030-1e0066000350
networkids=e7d3308c-03fc-4411-998d-ff45a2c1fccc
serviceofferingid=c1ebd091-57a6-427a-99a9-6c482de84a4f
{
"virtualmachine": {
"account": "admin",
...
}
}
(localcloud) 🐱 > delete serviceoffering
id=c1ebd091-57a6-427a-99a9-6c482de84a4f
{
"success": true
}
(localcloud) 🐱 > deploy virtualmachine
zoneid=7c9769a1-ba70-4f3a-a976-5a6ae7d946bb
templateid=936f5eda-6be2-11ed-a030-1e0066000350
networkids=e7d3308c-03fc-4411-998d-ff45a2c1fccc
serviceofferingid=c1ebd091-57a6-427a-99a9-6c482de84a4f
🙈 Error: (HTTP 431, error code 4350) service offering is Inactive:
c1ebd091-57a6-427a-99a9-6c482de84a4f
```
<!-- Please read the
[CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md)
document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
