DaanHoogland commented on code in PR #6840:
URL: https://github.com/apache/cloudstack/pull/6840#discussion_r1082594654
##########
server/src/main/java/com/cloud/storage/snapshot/SnapshotManagerImpl.java:
##########
@@ -1251,6 +1256,12 @@ public SnapshotInfo takeSnapshot(VolumeInfo volume)
throws ResourceAllocationExc
SnapshotInfo snapshotOnPrimary =
snapshotStrategy.takeSnapshot(snapshot);
boolean backupSnapToSecondary =
SnapshotInfo.BackupSnapshotAfterTakingSnapshot.value() == null ||
SnapshotInfo.BackupSnapshotAfterTakingSnapshot.value();
+ if (backupSnapToSecondary) {
+ DataCenterVO zone =
dataCenterDao.findById(snapshot.getDataCenterId());
+ if (DataCenter.Type.Edge.equals(zone.getType())) {
+ backupSnapToSecondary = false;
+ }
+ }
Review Comment:
@shwstppr can you put this in a separate method?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
