DaanHoogland commented on code in PR #6924:
URL: https://github.com/apache/cloudstack/pull/6924#discussion_r1094183589
##########
api/src/main/java/org/apache/cloudstack/api/command/admin/user/UpdateUserCmd.java:
##########
@@ -79,6 +79,9 @@ public class UpdateUserCmd extends BaseCmd {
@Parameter(name = ApiConstants.USERNAME, type = CommandType.STRING,
description = "Unique username")
private String username;
+ @Parameter(name = ApiConstants.MANDATE_2FA, type = CommandType.BOOLEAN,
description = "Provide true to mandate the user to use two factor
authentication has to be enabled. This parameter is only used to mandate 2FA,
not to disable 2FA")
Review Comment:
```suggestion
@Parameter(name = ApiConstants.MANDATE_2FA, type = CommandType.BOOLEAN,
description = "Provide true to mandate the user to use two factor
authentication has to be enabled. This parameter is only used to mandate 2FA,
not to disable 2FA", since = "4.18.0.0")
```
##########
api/src/main/java/org/apache/cloudstack/api/response/UserResponse.java:
##########
@@ -120,6 +120,10 @@ public class UserResponse extends BaseResponse implements
SetResourceIconRespons
@Param(description = "Base64 string representation of the resource icon",
since = "4.16.0.0")
ResourceIconResponse icon;
+ @SerializedName(ApiConstants.IS_2FA_ENABLED)
+ @Param(description = "true if user has two factor authentication enabled",
since = "4.18.0.0")
Review Comment:
would since be needed on output parameters? if so these shhould be added on
`LoginCmdResponse` as well.
##########
plugins/network-elements/juniper-contrail/src/test/java/org/apache/cloudstack/network/contrail/management/MockAccountManager.java:
##########
@@ -24,9 +24,12 @@
import javax.inject.Inject;
import javax.naming.ConfigurationException;
+import com.cloud.api.auth.SetupUserTwoFactorAuthenticationCmd;
Review Comment:
we must really stop putting new classes in `com.cloud` packages. `package
org.apache.cloudstack.api.auth;` works just as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
