DaanHoogland commented on PR #7234: URL: https://github.com/apache/cloudstack/pull/7234#issuecomment-1445024661
> Sure, @DaanHoogland, I approve the feature based on my testing, which was carried out using a similar approach to the PR owner. > > I tested the change by creating a VR and verifying its dumpxml to confirm that cpushares tag was set correctly. Specifically, I confirmed that the tag: > ``` > <cputune> > <shares>500</shares> > </cputune> > ``` > were properly defined, which confirmed that the change was successful. Great work @ezntt , we have a rule to have at least one lgtm based on code review and one lgtm based on 3rd party testing. Hence my question. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
