weizhouapache commented on code in PR #7304:
URL: https://github.com/apache/cloudstack/pull/7304#discussion_r1123266260


##########
scripts/util/keystore-cert-import:
##########
@@ -121,6 +121,10 @@ if [ -f "$LIBVIRTD_FILE" ]; then
     ln -sf /etc/pki/libvirt/servercert.pem /etc/pki/libvirt-vnc/server-cert.pem
     ln -sf /etc/pki/libvirt/private/serverkey.pem 
/etc/pki/libvirt-vnc/server-key.pem
     cloudstack-setup-agent -s > /dev/null
+
+    QEMU_GROUP=$(cat /etc/group | awk -F: '{ print $1}' | grep qemu)
+    chgrp $QEMU_GROUP /etc/pki/libvirt /etc/pki/libvirt-vnc /etc/pki/CA 
/etc/pki/libvirt/private /etc/pki/libvirt/servercert.pem 
/etc/pki/libvirt/private/serverkey.pem /etc/pki/CA/cacert.pem 
/etc/pki/libvirt-vnc/ca-cert.pem /etc/pki/libvirt-vnc/server-cert.pem 
/etc/pki/libvirt-vnc/server-key.pem

Review Comment:
   @nvazquez 
   since the user/group is specified in `/etc/libvirt/qemu.conf`, should the 
group be fetched from qemu.conf ?
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to