weizhouapache commented on PR #7269: URL: https://github.com/apache/cloudstack/pull/7269#issuecomment-1456076724
> Hi @weizhouapache > > Can you make nodejs (>= 14) > > Since nodejs 12 is not supported by ubuntu 22.04 release and is deprecated > > https://deb.nodesource.com/node_12.x/dists/ > > There is ubuntu 22.04 -Jammy in node_14.x which is LTS > > https://deb.nodesource.com/node_14.x/dists/ > > Also is "dh-systemd" required for a successful build ? > > As per https://bugs.debian.org/822670, the dh-systemd package has been merged with the main debhelper package since version 9.20160709 > > On Ubuntu 22.04 (Jammy) the dh-systemd package has been completely removed, @kiranchavala thanks for your review. since debian/control is also used when build package on ubuntu 20.04, it should be compatible with ubuntu 20.04 as well 22.04 for example, `dh-systemd | debhelper (>= 13)` means both dh-systemd (on ubuntu 20.04) and debhelper (>=13) on ubuntu 22.04 work. The change for nodejs makes sense. The version has been update in PR #6956 https://github.com/apache/cloudstack/pull/6956/files#diff-6e8c08cff231f603dfa7a4d5f873a6fee6e5c730d431c113bbf5b1180c6983e4 However, I need to check if nodejs verison has been changed in our container for deb packaging. If it still uses nodejs12, the packaging jobs will fail if this is merged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
