stephankruggg commented on code in PR #7321:
URL: https://github.com/apache/cloudstack/pull/7321#discussion_r1130872218
##########
api/src/main/java/com/cloud/vm/UserVmService.java:
##########
@@ -438,16 +435,10 @@ UserVm createVirtualMachine(DeployVMCmd cmd) throws
InsufficientCapacityExceptio
/**
* Migrate the given VM to the destination host provided. The API returns
the migrated VM if migration succeeds.
- * Only Root
- * Admin can migrate a VM.
+ * Only Root Admin can migrate a VM.
*
- * @param destinationStorage
- * TODO
- * @param Long
- * vmId
- * vmId of The VM to migrate
- * @param Host
- * destinationHost to migrate the VM
+ * @param vmId the id of the VM to be migrated
Review Comment:
```suggestion
* @param vmId The ID of the VM to be migrated
```
##########
api/src/main/java/com/cloud/vm/UserVmService.java:
##########
@@ -466,14 +458,9 @@ VirtualMachine migrateVirtualMachine(Long vmId, Host
destinationHost) throws Res
* Migrate the given VM with its volumes to the destination host. The API
returns the migrated VM if it succeeds.
* Only root admin can migrate a VM.
*
- * @param destinationStorage
- * TODO
- * @param Long
- * vmId of The VM to migrate
- * @param Host
- * destinationHost to migrate the VM
- * @param Map
- * A map of volume to which pool it should be migrated
+ * @param vmId of The VM to migrate
Review Comment:
```suggestion
* @param vmId The ID of the VM to be migrated
```
##########
api/src/main/java/com/cloud/vm/UserVmService.java:
##########
@@ -438,16 +435,10 @@ UserVm createVirtualMachine(DeployVMCmd cmd) throws
InsufficientCapacityExceptio
/**
* Migrate the given VM to the destination host provided. The API returns
the migrated VM if migration succeeds.
- * Only Root
- * Admin can migrate a VM.
+ * Only Root Admin can migrate a VM.
*
- * @param destinationStorage
- * TODO
- * @param Long
- * vmId
- * vmId of The VM to migrate
- * @param Host
- * destinationHost to migrate the VM
+ * @param vmId the id of the VM to be migrated
+ * @param destinationHost destinationHost to migrate the VM
Review Comment:
```suggestion
* @param destinationHost The destination host to where the VM will be
migrated
```
##########
api/src/main/java/com/cloud/vm/UserVmService.java:
##########
@@ -466,14 +457,9 @@ VirtualMachine migrateVirtualMachine(Long vmId, Host
destinationHost) throws Res
* Migrate the given VM with its volumes to the destination host. The API
returns the migrated VM if it succeeds.
* Only root admin can migrate a VM.
*
- * @param destinationStorage
- * TODO
- * @param Long
- * vmId of The VM to migrate
- * @param Host
- * destinationHost to migrate the VM
- * @param Map
- * A map of volume to which pool it should be migrated
+ * @param vmId of The VM to migrate
+ * @param destinationHost destination host to migrate the VM
Review Comment:
```suggestion
* @param destinationHost The destination host to where the VM will be
migrated
```
##########
api/src/main/java/com/cloud/vm/UserVmService.java:
##########
@@ -404,10 +404,7 @@ UserVm createAdvancedVirtualMachine(DataCenter zone,
ServiceOffering serviceOffe
/**
* Creates a vm group.
*
- * @param name
- * - name of the group
- * @param accountId
- * - accountId
+ * @param cmd The command specifying domain id, account name, group name,
and project id
Review Comment:
```suggestion
* @param cmd The command specifying domain ID, account name, group
name, and project ID
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
