DaanHoogland commented on code in PR #7368:
URL: https://github.com/apache/cloudstack/pull/7368#discussion_r1149243051
##########
server/src/main/java/com/cloud/api/query/QueryManagerImpl.java:
##########
@@ -2607,6 +2608,13 @@ private Pair<List<StoragePoolJoinVO>, Integer>
searchForStoragePoolsInternal(Lis
throw new InvalidParameterValueException("Invalid scope type:
" + cmd.getScope());
}
}
+ StoragePoolStatus state = null;
+ if (cmd.getState() != null) {
+ state = EnumUtils.getEnumIgnoreCase(StoragePoolStatus.class,
cmd.getState());
+ if (state == null) {
+ throw new InvalidParameterValueException("Invalid state: " +
cmd.getState());
+ }
+ }
Review Comment:
you are adding too an already too complex method here. Can you extract
and/or refactor please?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
