GutoVeronezi opened a new pull request, #7417: URL: https://github.com/apache/cloudstack/pull/7417
### Description This PR is a follow up of the discussion we had in the thread https://lists.apache.org/thread/qvb3kx78m7lvc21d90ld00v8o8wd27r. For changes in database `VIEW`s, currently, we have to look at the changes in the previous `schema` files and replicate the whole `CREATE VIEW` command in the current `schema` file, modifying what we need (adding/removing columns, and so on). This process makes the changes in a `VIEW` to be distributed through several files, increasing the number of lines modified for simple changes (e.g.: for adding a single field to the `VIEW` result we need to replicate the whole command); thus, making it difficult to maintain and track. With that in mind, the proposal is to, instead of adding the `VIEW` changes to the `schema` files, we manage them in a separated file (or several files). That would allow us to easily track `VIEW` modifications, as we would just change the `VIEW` declaration in the same file, instead of re-declaring the whole `VIEW` in a different file; and we would have a better history of the changes. Also, we would not need to migrate all `VIEW`s right away; we could migrate as we change them (I already created some files according to what was changed in 4.18). ### Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [ ] Bug fix (non-breaking change which fixes an issue) - [x] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) ### Feature/Enhancement Scale or Bug Severity #### Feature/Enhancement Scale - [ ] Major - [x] Minor ### How Has This Been Tested? I created an environment from scratch and observed the upgrade logs: [management-server.log.tar.gz](https://github.com/apache/cloudstack/files/11182439/management-server.log.tar.gz) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
