DaanHoogland commented on code in PR #6841:
URL: https://github.com/apache/cloudstack/pull/6841#discussion_r1188780567
##########
engine/schema/src/main/java/com/cloud/storage/dao/GuestOSHypervisorDaoImpl.java:
##########
@@ -157,7 +157,7 @@ public List<GuestOSHypervisorVO>
listByOsNameAndHypervisorMinimumVersion(String
sc.and(sc.entity().getGuestOsName(), SearchCriteria.Op.EQ,
guestOsName);
sc.and(sc.entity().getHypervisorType(), SearchCriteria.Op.EQ,
hypervisorType);
sc.and().op(sc.entity().getHypervisorVersion(),
SearchCriteria.Op.GTEQ, minHypervisorVersion);
- sc.or(sc.entity().getHypervisorVersion(), SearchCriteria.Op.NEQ,
"default");
+ sc.or(sc.entity().getHypervisorVersion(), SearchCriteria.Op.EQ,
"default");
Review Comment:
no, default is not part of the simver and it is OR'ed so I think EQ is good
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
