vishesh92 commented on code in PR #7584:
URL: https://github.com/apache/cloudstack/pull/7584#discussion_r1214161720
##########
server/src/main/java/com/cloud/network/element/ConfigDriveNetworkElement.java:
##########
@@ -573,6 +575,10 @@ private boolean deleteConfigDriveIsoOnHostCache(final
VirtualMachine vm, final L
LOG.warn(String.format("Host %s appears to be unavailable,
skipping deletion of config-drive ISO on host cache", hostId));
return false;
}
+ if (!Arrays.asList(Status.Up,
Status.Connecting).contains(hostVO.getStatus())) {
+ LOG.warn(String.format("Host status %s is not Up or Connecting,
skipping deletion of config-drive ISO on host cache", hostId));
Review Comment:
@rohityadavcloud This returns false if the status is NOT `Up` or
`Connecting`..
I matching the checks which are present here:
https://github.com/apache/cloudstack/blob/4.18/engine/orchestration/src/main/java/com/cloud/agent/manager/AgentManagerImpl.java#L970
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
