DaanHoogland commented on PR #7718: URL: https://github.com/apache/cloudstack/pull/7718#issuecomment-1653150190
> > > Same code `hypervisor=self.hypervisor` is used across different tests so I'm not completely sure about this change > > > > > > agree with @shwstppr . code looks ok. but I am also wondering if we need this change and what the benefit is. > > The real issue is #7717; the hypervisor is not set correctly in the test client, but for these tests it is irrelevant so no reason to set it. Just getting the template is effectively the same action. a test env with a mixed zone may not be able to execute it but only if the hypervisor type is explicitely set to one for which a template is not of the default hypervisortype. The test assumes intelligence that it doesn't have itself. @shwstppr @weizhouapache , is this explanation enough? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
