soreana commented on issue #7776: URL: https://github.com/apache/cloudstack/issues/7776#issuecomment-1653467025
> > > > @DaanHoogland yes error can be thrown, I think this is a design thought. Last time I just logged a message, didn't want to break the backward compatibility. > > > > https://github.com/apache/cloudstack/blob/41bbedb530e2e94016525adc67e6642cb48ef2c8/server/src/main/java/com/cloud/network/NetworkServiceImpl.java#L1405-L1406 > > > > > > > > > that message is an info in case "either projectId or accountname and domainId are not provided". I think we can split between that case and when `domainid` _is_ provided but `projectId or accountname` are not. This is a minor issue, but it makes sense to return an error in those cases. (if we all agree!) > > > > > > @DaanHoogland yes, thrown an error message if > > ``` > > * acltype is Account, and > > > > * domainid is passed, and > > > > * account name and projectid are not passed > > ``` > > > > > > > > > > > > > > > > > > > > > > > > in my opinion, there will be more trouble than benefit. (the behaviour has existed for many years) > > ok, agree @soreana ? @DaanHoogland Yeah, that is makes sense, CloudStack should throw an error when only the domain id is provided. Btw, @DaanHoogland @harikrishna-patnala @weizhouapache the `createNetwork` API call was a tip of an ice burg, even if we make it works other API calls still have an issue, I've tested a few (`deployVirtualmachine`, `createSnapshot`, `createVolume` ) they are all have the same issue ... ``` (localcloud) > deploy virtualmachine domainid=<domain id> networkids=<network id> serviceofferingid=<service offering id> templateid=<template id> zoneid=<zone id> { "virtualmachine": { "account": "admin", .. "domain": "ROOT", "domainid": "ea2dcd59-249f-11ee-bb7d-1e000d003377", ... } } (localcloud) > create snapshot domainid=<domain id> volumeid=<volume id> { "snapshot": { "account": "admin", "domain": "ROOT", "domainid": "ea2dcd59-249f-11ee-bb7d-1e000d003377", .. } } (localcloud) > create volume domainid=<domain id> snapshotid=<snapshot id> { "volume": { "account": "admin", ... "domain": "ROOT", "domainid": "ea2dcd59-249f-11ee-bb7d-1e000d003377", ... } } ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
