DaanHoogland commented on PR #7805: URL: https://github.com/apache/cloudstack/pull/7805#issuecomment-1663914910
> > > looks good, not sure if the console proxy should be excluded though > > > > > > Hey @DaanHoogland when you run this new hook for the first time it finds that list of keys in the codebase. > > So I was then excluding them assuming they were all valid keys that we need. > > yeah, makes sense and I have no doubts about most (systemvm and tests) . I'll need to look at the consoleproxy one. false alarm (didn't notice this is in a test dir as well) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
