BryanMLima commented on code in PR #6812:
URL: https://github.com/apache/cloudstack/pull/6812#discussion_r1287011719
##########
framework/db/src/main/java/com/cloud/utils/crypt/EncryptionSecretKeyChanger.java:
##########
@@ -497,6 +499,30 @@ private boolean migrateData(String oldDBKey, String
newDBKey, String oldEncrypto
return true;
}
+ private void migrateEncryptedAccountDetails(Connection conn) {
+ System.out.println("Beginning migration of account_details encrypted
values");
+
+ String tableName = "account_details";
+ String selectSql = "SELECT details.id, details.value from
account_details details, cloud.configuration c " +
+ "WHERE details.name = c.name AND c.category NOT IN ('Hidden',
'Secure') AND details.value <> \"\" ORDER BY details.id;";
+ String updateSql = "UPDATE cloud.account_details SET value = ? WHERE
id = ?;";
+ migrateValueAndUpdateDatabaseById(conn, tableName, selectSql,
updateSql, false);
+
+ System.out.println("End migration of account details values");
Review Comment:
Same here.
##########
framework/db/src/main/java/com/cloud/utils/crypt/EncryptionSecretKeyChanger.java:
##########
@@ -497,6 +499,30 @@ private boolean migrateData(String oldDBKey, String
newDBKey, String oldEncrypto
return true;
}
+ private void migrateEncryptedAccountDetails(Connection conn) {
+ System.out.println("Beginning migration of account_details encrypted
values");
+
+ String tableName = "account_details";
+ String selectSql = "SELECT details.id, details.value from
account_details details, cloud.configuration c " +
+ "WHERE details.name = c.name AND c.category NOT IN ('Hidden',
'Secure') AND details.value <> \"\" ORDER BY details.id;";
+ String updateSql = "UPDATE cloud.account_details SET value = ? WHERE
id = ?;";
+ migrateValueAndUpdateDatabaseById(conn, tableName, selectSql,
updateSql, false);
+
+ System.out.println("End migration of account details values");
+ }
+
+ private void migrateEncryptedDomainDetails(Connection conn) {
+ System.out.println("Beginning migration of domain_details encrypted
values");
+
+ String tableName = "domain_details";
+ String selectSql = "SELECT details.id, details.value from
domain_details details, cloud.configuration c " +
+ "WHERE details.name = c.name AND c.category NOT IN ('Hidden',
'Secure') AND details.value <> \"\" ORDER BY details.id;";
+ String updateSql = "UPDATE cloud.account_details SET value = ? WHERE
id = ?;";
+ migrateValueAndUpdateDatabaseById(conn, tableName, selectSql,
updateSql, false);
+
+ System.out.println("End migration of domain details values");
Review Comment:
Same here.
##########
framework/db/src/main/java/com/cloud/utils/crypt/EncryptionSecretKeyChanger.java:
##########
@@ -497,6 +499,30 @@ private boolean migrateData(String oldDBKey, String
newDBKey, String oldEncrypto
return true;
}
+ private void migrateEncryptedAccountDetails(Connection conn) {
+ System.out.println("Beginning migration of account_details encrypted
values");
+
+ String tableName = "account_details";
+ String selectSql = "SELECT details.id, details.value from
account_details details, cloud.configuration c " +
+ "WHERE details.name = c.name AND c.category NOT IN ('Hidden',
'Secure') AND details.value <> \"\" ORDER BY details.id;";
+ String updateSql = "UPDATE cloud.account_details SET value = ? WHERE
id = ?;";
+ migrateValueAndUpdateDatabaseById(conn, tableName, selectSql,
updateSql, false);
+
+ System.out.println("End migration of account details values");
+ }
+
+ private void migrateEncryptedDomainDetails(Connection conn) {
+ System.out.println("Beginning migration of domain_details encrypted
values");
Review Comment:
Same here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
