weizhouapache commented on code in PR #7082:
URL: https://github.com/apache/cloudstack/pull/7082#discussion_r1290055358
##########
api/src/main/java/org/apache/cloudstack/api/command/user/offering/ListServiceOfferingsCmd.java:
##########
@@ -82,6 +83,12 @@ public class ListServiceOfferingsCmd extends
BaseListDomainResourcesCmd {
since = "4.15")
private Integer cpuSpeed;
+ @Parameter(name = ApiConstants.ACCOUNT, type = CommandType.STRING,
description = "list resources by account. Must be used with the domainId
parameter.")
Review Comment:
@RodrigoDLopez
same here, you can use `BaseListProjectAndAccountResourcesCmd`
##########
api/src/main/java/org/apache/cloudstack/api/command/user/offering/ListDiskOfferingsCmd.java:
##########
@@ -44,6 +45,12 @@ public class ListDiskOfferingsCmd extends
BaseListDomainResourcesCmd {
@Parameter(name = ApiConstants.NAME, type = CommandType.STRING,
description = "name of the disk offering")
private String diskOfferingName;
+ @Parameter(name = ApiConstants.ACCOUNT, type = CommandType.STRING,
description = "list resources by account. Must be used with the domainId
parameter.")
Review Comment:
@RodrigoDLopez
you can use `BaseListProjectAndAccountResourcesCmd` instead of
`BaseListDomainResourcesCmd`
then these are not needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
