weizhouapache commented on PR #7845: URL: https://github.com/apache/cloudstack/pull/7845#issuecomment-1673331005
> > > change looks sane, but does the docker build need to delete the .git directory @weizhouapache ? > > > > > > @DaanHoogland I have no idea how github action pulls the code, it seems .git directory is missing in the build container. https://github.com/apache/cloudstack/blob/main/.github/workflows/docker-cloudstack-simulator.yml > > ok, if it is otherwise out of our control let's merge yes. we could also consider that some users download the source code tarball from cloudstack website, which does not have .git directory as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
