weizhouapache commented on code in PR #7799:
URL: https://github.com/apache/cloudstack/pull/7799#discussion_r1291549584
##########
engine/schema/src/main/resources/META-INF/db/schema-41720to41800.sql:
##########
@@ -1568,4 +1568,6 @@ UPDATE
SET
usage_type = 22
WHERE
- usage_type = 24 AND usage_display like '% io write';
\ No newline at end of file
+ usage_type = 24 AND usage_display like '% io write';
+
+CALL `cloud`.`IDEMPOTENT_ADD_COLUMN`('cloud.guest_os', 'display', 'tinyint(1)
DEFAULT ''1'' COMMENT ''should this guest_os be shown to the end user'' ');
Review Comment:
@DaanHoogland
as we discussed, add this to 4.16.0->4.16.1->4.17.0->4.17.1->4.17.2 as well ?
##########
engine/schema/src/main/java/com/cloud/upgrade/GuestOsMapper.java:
##########
@@ -72,19 +72,17 @@ private void makeNormative(GuestOSVO guestOSVO,
Set<GuestOSVO> setOfGuestOSes) {
for (GuestOSVO oldGuestOs : setOfGuestOSes) {
Review Comment:
skip `if (oldGuestOs.getId() == guestOSVO.getId())` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
