shwstppr commented on code in PR #7609:
URL: https://github.com/apache/cloudstack/pull/7609#discussion_r1295326997
##########
ui/src/components/header/HeaderNotice.vue:
##########
@@ -108,8 +108,12 @@ export default {
this.$store.watch(
(state, getters) => getters.headerNotices,
(newValue, oldValue) => {
- if (oldValue !== newValue && newValue !== undefined) {
- this.notices = newValue.reverse()
+ if (newValue !== undefined) {
+ return
+ }
+ const reversedNewValue = newValue.reverse()
+ if (oldValue !== reversedNewValue) {
+ this.notices = reversedNewValue
Review Comment:
@DaanHoogland I'm not sure about the length check at the moment. I've just
fixed the existing check therefore
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
