weizhouapache commented on code in PR #7877:
URL: https://github.com/apache/cloudstack/pull/7877#discussion_r1298264421
##########
server/src/main/java/com/cloud/network/router/NetworkHelperImpl.java:
##########
@@ -618,7 +616,7 @@ protected List<HypervisorType> getHypervisors(final
RouterDeploymentDefinition r
throw new InsufficientServerCapacityException("Unable to create
virtual router, there are no clusters in the zone." +
getNoHypervisorsErrMsgDetails(),
DataCenter.class, dest.getDataCenter().getId());
}
- return hypervisors;
+ return new ArrayList(new LinkedHashSet<>(hypervisors));
Review Comment:
@DaanHoogland
right.
I was thinking about it, but if we define it as a Set, we need to convert
the following from List to Set
```
hypervisors =
_resourceMgr.getSupportedHypervisorTypes(dest.getDataCenter().getId(), true,
routerDeploymentDefinition.getPlan().getPodId());
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
