JoaoJandre commented on PR #7131: URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1692311437
> > @JoaoJandre cloudstack-utils.jar should work without any other dependency. log4j should be included in the cloudstack-utils.jar > > What Daan made, is a workaround, not a the final solution. > > @JoaoJandre could you please apply the changes below ? > > ``` > diff --git a/utils/pom.xml b/utils/pom.xml > index 46897031d14..14b05c8706b 100755 > --- a/utils/pom.xml > +++ b/utils/pom.xml > @@ -269,6 +269,8 @@ > <include>commons-codec:commons-codec</include> > <include>org.apache.commons:commons-lang3</include> > <include>org.jasypt:jasypt</include> > + <include>org.apache.logging.log4j:log4j-core</include> > + <include>org.apache.logging.log4j:log4j-api</include> > </includes> > </artifactSet> > </configuration> > ``` > > it looks good in my testing > > ``` > [INFO] --- maven-shade-plugin:3.0.0:shade (rebuild-war) @ cloud-utils --- > [INFO] Excluding org.apache.cloudstack:cloud-framework-managed-context:jar:4.19.0.0-SNAPSHOT from the shaded jar. > [INFO] Excluding org.apache.cloudstack:cloud-framework-ca:jar:4.19.0.0-SNAPSHOT from the shaded jar. > [INFO] Excluding org.springframework:spring-context:jar:5.3.26 from the shaded jar. > [INFO] Excluding org.springframework:spring-aop:jar:5.3.26 from the shaded jar. > [INFO] Excluding org.springframework:spring-beans:jar:5.3.26 from the shaded jar. > [INFO] Excluding org.springframework:spring-core:jar:5.3.26 from the shaded jar. > [INFO] Excluding org.springframework:spring-jcl:jar:5.3.26 from the shaded jar. > [INFO] Excluding org.springframework:spring-expression:jar:5.3.26 from the shaded jar. > [INFO] Excluding org.aspectj:aspectjweaver:jar:1.8.13 from the shaded jar. > [INFO] Including org.apache.logging.log4j:log4j-core:jar:2.19.0 in the shaded jar. > [INFO] Including org.apache.logging.log4j:log4j-api:jar:2.19.0 in the shaded jar. > ...... > ``` @weizhouapache The tests will run, but if you read the comment I pointed out, you will find that the system VMs will stop logging. Please, do try it, log into the system VMs with this change you proposed, and see if there is any logging. If there is, I'll be happy to comply. Moreover, ACS is working perfectly without this change. The only thing that broke is the CI, and only because the CI is "manually" calling the EncriptorCLI without passing the proper classpath. This was already discussed and solved with @DaanHoogland. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
