GutoVeronezi commented on code in PR #7712:
URL: https://github.com/apache/cloudstack/pull/7712#discussion_r1308679389


##########
api/src/main/java/org/apache/cloudstack/vm/UnmanagedInstanceTO.java:
##########
@@ -136,6 +137,10 @@ public List<Nic> getNics() {
     public void setNics(List<Nic> nics) {
         this.nics = nics;
     }
+    public String getVncPasswd(){ return vncPasswd; }
+    public void setVncPasswd(String vncPasswd) { this.vncPasswd = vncPasswd; }

Review Comment:
   ```suggestion
       public String getVncPassword() { 
           return vncPassword;
       }
       
       public void setVncPassword (String vncPasswd) { 
           this.vncPasswd = vncPasswd; 
       }
   ```
   
   Suggestion to comply with our [coding 
convention](https://cwiki.apache.org/confluence/display/CLOUDSTACK/Coding+conventions).



##########
api/src/main/java/org/apache/cloudstack/vm/UnmanagedInstanceTO.java:
##########
@@ -48,6 +48,7 @@ public enum PowerState {
     private List<Disk> disks;
 
     private List<Nic> nics;
+    private String vncPasswd;

Review Comment:
   ```suggestion
       private String vncPassword;
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to