nvazquez commented on code in PR #7881:
URL: https://github.com/apache/cloudstack/pull/7881#discussion_r1310909151
##########
engine/storage/src/main/java/org/apache/cloudstack/storage/endpoint/DefaultEndPointSelector.java:
##########
@@ -84,7 +85,8 @@ public class DefaultEndPointSelector implements
EndPointSelector {
+ "left join host_details hd on h.id=hd.host_id
and hd.name='" + HOST_VOLUME_ENCRYPTION + "' "
+ "where h.status = 'Up' and h.type = 'Routing'
and h.resource_state = 'Enabled' and s.pool_id = ? ";
- private String findOneHypervisorHostInScopeByType = "select h.id from host
h where h.status = 'Up' and h.hypervisor_type = ? ";
+ private String findOneHypervisorHostInScopeByHypervisorType = "select h.id
from " +
+ "host h where h.status = 'Up' and h.type = 'Routing' and
h.resource_state = 'Enabled' and h.hypervisor_type = ? ";
Review Comment:
Ah, good point, thanks
##########
engine/storage/src/main/java/org/apache/cloudstack/storage/endpoint/DefaultEndPointSelector.java:
##########
@@ -84,7 +85,8 @@ public class DefaultEndPointSelector implements
EndPointSelector {
+ "left join host_details hd on h.id=hd.host_id
and hd.name='" + HOST_VOLUME_ENCRYPTION + "' "
+ "where h.status = 'Up' and h.type = 'Routing'
and h.resource_state = 'Enabled' and s.pool_id = ? ";
- private String findOneHypervisorHostInScopeByType = "select h.id from host
h where h.status = 'Up' and h.hypervisor_type = ? ";
+ private String findOneHypervisorHostInScopeByHypervisorType = "select h.id
from " +
+ "host h where h.status = 'Up' and h.type = 'Routing' and
h.resource_state = 'Enabled' and h.hypervisor_type = ? ";
Review Comment:
Ah, good point, yes they can, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
