DaanHoogland opened a new pull request, #7931: URL: https://github.com/apache/cloudstack/pull/7931
### Description This PR attempts to load items (PoC for domains on the network creation tab) in case there is more to load than the default 500 maximum. This should be generalised to a mechanism that applies to any dropdown UI item, but is now only for a particular instance. <!--- Describe your changes in DETAIL - And how has behaviour functionally changed. --> <!-- For new features, provide link to FS, dev ML discussion etc. --> <!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. --> <!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged --> <!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" --> <!-- Fixes: # --> <!--- ********************************************************************************* --> <!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. --> <!--- PLEASE PUT AN 'X' in only **ONE** box --> <!--- ********************************************************************************* --> ### Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) ### Feature/Enhancement Scale or Bug Severity #### Feature/Enhancement Scale - [ ] Major - [ ] Minor #### Bug Severity - [ ] BLOCKER - [ ] Critical - [ ] Major - [ ] Minor - [ ] Trivial ### Screenshots (if appropriate): ### How Has This Been Tested? <!-- Please describe in detail how you tested your changes. --> <!-- Include details of your testing environment, and the tests you ran to --> <!-- see how your change affects other areas of the code, etc. --> <!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document --> create loads of domains 26*((26*3)+26)+1 and in the network create dialog add one by typing a partial name that is beyond the 500 mark. I create domains a-z with subdomain <x>a through <x>z and sub-sub-domain 1st, 2nd and 3rd What is still missing is searching for the last 3rd for instance. There are 26*26 (676) domains named 3rd, and if I want to select the last one. A thing that may also be missing in the domain overview search and in the results of #7766 , this does address the comment in https://github.com/apache/cloudstack/pull/7766#pullrequestreview-1549019223 but as said, not in a generic way (yet) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
