GutoVeronezi commented on code in PR #7923:
URL: https://github.com/apache/cloudstack/pull/7923#discussion_r1311545609
##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java:
##########
@@ -1319,13 +1319,13 @@ protected void setupMemoryBalloonStatsPeriod(Connect
conn) {
}
}
- private void enableSSLForKvmAgent(final Map<String, Object> params) {
+ private void enableSSLForKvmAgent() {
Review Comment:
I see. Before instantiating `Agent`, `AgentShell#Init` loads the properties
from `agent.properties`; as we are not using `_shell.getProperties()` anymore,
the map passed to `LibvirtComputingResource#enableSSLForKvmAgent` does not have
the passphrase anymore. Makes sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
