mlsorensen opened a new pull request, #7964: URL: https://github.com/apache/cloudstack/pull/7964
### Description This PR allows admin to set a "cloud-name" for cloud-init metadata. Configdrive has no special handling to determine what cloud it is being run on, it just generically sets the cloud-name to the datasource name. By providing this metadata key, we can allow admin to configure this for users. Followed the same pattern for adding "cloud-domain" and other metadata. ### Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [ ] Bug fix (non-breaking change which fixes an issue) - [x] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) ### Feature/Enhancement Scale or Bug Severity #### Feature/Enhancement Scale - [ ] Major - [x] Minor #### Bug Severity - [ ] BLOCKER - [ ] Critical - [ ] Major - [ ] Minor - [x] Trivial ### Screenshots (if appropriate): ### How Has This Been Tested? Tested locally by first keeping the value unset and confirming there is no change to the data ``` # cloud-init query cloud-name configdrive ``` Then set the config key `metadata.custom.cloud.name` and confirmed it was reflected in the VM ``` # cloud-init query cloud-name marcuscloud ``` Also tested it works with VR as userdata provider: ``` $ curl http://192.168.151.10/latest/meta-data/cloud-name marcuscloud ``` <!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
