DaanHoogland commented on code in PR #8022:
URL: https://github.com/apache/cloudstack/pull/8022#discussion_r1343723344
##########
server/src/test/java/com/cloud/api/query/dao/TemplateJoinDaoImplTest.java:
##########
@@ -111,5 +127,28 @@ private void populateTemplateJoinVO() {
ReflectionTestUtils.setField(template, "domainName", domainName);
ReflectionTestUtils.setField(template, "detailName", detailName);
ReflectionTestUtils.setField(template, "detailValue", detailValue);
+ ReflectionTestUtils.setField(template, "templateType", templateType);
+ }
+
+ @Test
+ public void testNewUpdateResponseForVnf() {
+ ReflectionTestUtils.setField(template, "id", templateId);
+ ReflectionTestUtils.setField(template, "templateType", templateType);
+
+ VnfTemplateNicVO vnfNic1 = new VnfTemplateNicVO(templateId, 0L,
"eth0", true, true, "first");
+ VnfTemplateNicVO vnfNic2 = new VnfTemplateNicVO(templateId, 1L,
"eth1", true, true, "second");
+ Mockito.doReturn(Arrays.asList(vnfNic1,
vnfNic2)).when(vnfTemplateNicDao).listByTemplateId(templateId);
+
+ VnfTemplateDetailVO detail1 = new VnfTemplateDetailVO(templateId,
"name1", "value1", true);
+ VnfTemplateDetailVO detail2 = new VnfTemplateDetailVO(templateId,
"name2", "value2", true);
+ VnfTemplateDetailVO detail3 = new VnfTemplateDetailVO(templateId,
"name3", "value3", true);
+ Mockito.doReturn(Arrays.asList(detail1, detail2,
detail3)).when(vnfTemplateDetailsDao).listDetails(templateId);
+
+ final TemplateResponse response =
_templateJoinDaoImpl.newUpdateResponse(template);
+ Assert.assertTrue(response instanceof VnfTemplateResponse);
+ Assert.assertEquals(2,
((VnfTemplateResponse)response).getVnfNics().size());
+ Assert.assertEquals(3,
((VnfTemplateResponse)response).getVnfDetails().size());
+
}
}
+
Review Comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
