oscaralvaro opened a new pull request, #8029:
URL: https://github.com/apache/cloudstack/pull/8029

   ### Description
   
   This PR...
   Improves the error messages to more accurately describe the reasons for 
failure to download a template. This is done via surfacing the underlying 
reason for the failure in the error message. This will facilitate 
troubleshooting.
   
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [x] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ### Feature/Enhancement Scale or Bug Severity
   
   #### Feature/Enhancement Scale
   
   - [ ] Major
   - [x] Minor
   
   #### Bug Severity
   
   - [ ] BLOCKER
   - [ ] Critical
   - [ ] Major
   - [x] Minor
   - [ ] Trivial
   
   
   ### Screenshots (if appropriate):
   
   Manual testing via setting up a development environment and triggering 
failures. Two scenarios were tested with below resulting error messages. 
Several other failure reasons will be surfaced as well.
   
   -Example: Template checksum mismatch
   Before:
   Unable to orchestrate start VM instance {id: "3112", name: "i-2-3112-VM", 
uuid: "db19b8af-00e0-4f7a-803b-a6c3b022ba5d", type="User"} due to [Template 203 
could not be downloaded on pool 1, failing after trying on several hosts].
   
   Now:
   Unable to orchestrate start VM instance {id: "3112", name: "i-2-3112-VM", 
uuid: "db19b8af-00e0-4f7a-803b-a6c3b022ba5d", type="User"} due to [Template 203 
could not be downloaded on pool 1, failing after trying on several hosts 
Details: Checksum validation failed].
   
   UI:
   
   ![Screenshot 2023-09-28 at 5 20 39 
PM](https://github.com/apache/cloudstack/assets/2266908/8fd39970-c8db-4cfb-b8ec-b59ba413f5c7)
   
   
   
   -Example: Wrong template url
   
   Before:
   Unable to orchestrate start VM instance {id:
   "3110", name: "¡-2-3110-VM", uuid:
   "40478bcf-5ffa-4a18-9d22-
   739d149df76", type="User") due to [Template 203 could not be downloaded on 
pool 1, failing after trying on several hosts].
   
   Now:
   Unable to orchestrate start VM instance {id:
   "3110", name: "¡-2-3110-VM", uuid:
   "40478bcf-5ffa-4a18-9d22-
   739d149df76", type="User") due to [Template 203 could not be downloaded on 
pool 1, failing after trying on several hosts Details: Unable to download 
template: Error on HTTPS response].
   
   UI:
   
   ![Screenshot 2023-09-28 at 5 19 26 
PM](https://github.com/apache/cloudstack/assets/2266908/b7b776f0-bb5d-47e5-886a-6ca14fec4106)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to