weizhouapache commented on issue #8040:
URL: https://github.com/apache/cloudstack/issues/8040#issuecomment-1748227804
> > > LibvirtComputingResource
> >
> >
> > I think option 2 is better. we could skip the vms if the name does not
start with i-/r-/s-/v- (not ideal but should work).
>
> couldn't the names start with those prefixes anyway (especially after
(un)manage for kvm is merged)? Not sure how feasible it is to get information
about that from the MS during this process. Maybe those are guaranteed to have
the correct ,...
@DaanHoogland
I think the challenge is, cloudstack agent cannot get the list of available
vms from management server during start. there are few options
(1) determine if vm belongs to cloudstack by vm name (prefix), but it will
not work if we import unmanaged vms in 4.19 as Daan said.
(2) determine if vm belongs to cloudstack by sysinfo, which were added in
commit 3894d34b
```
<sysinfo type='smbios'>
<system>
<entry name='manufacturer'>Apache Software Foundation</entry>
<entry name='product'>CloudStack KVM Hypervisor</entry>
<entry name='uuid'>0820a0ca-f7e8-470a-a4f9-7a58fb75a6e4</entry>
</system>
</sysinfo>
```
(3) add a try-catch block and ignore the error so that cloudstack-agent can
be started even if the vm xml cannot be parsed.
(4) move the `setupMemoryBalloonStatsPeriod` step out from start process
(added in #6358).
option 3 looks like the most simple.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
