GutoVeronezi commented on code in PR #7605:
URL: https://github.com/apache/cloudstack/pull/7605#discussion_r1350164129
##########
utils/src/main/java/com/cloud/utils/NumbersUtil.java:
##########
@@ -147,6 +149,26 @@ public static long parseInterval(String str, long
defaultValue) {
}
}
+ /**
+ * Formats a BigDecimal with the number formatter.
+ * @return
+ * <li>null if value is null;</li>
+ * <li>value.toString() if the numberFormat is null;</li>
+ * <li>the value formatted if both parameters are not null;</li>
+ */
+ public static String formatBigDecimalAccordingToNumberFormat(BigDecimal
value, NumberFormat numberFormat) {
Review Comment:
We could add some unit tests for this method.
##########
framework/quota/src/main/java/org/apache/cloudstack/quota/QuotaAlertManagerImpl.java:
##########
@@ -238,19 +248,29 @@ public void sendQuotaAlert(DeferredQuotaEmail
emailToBeSent) {
}
}
+ private NumberFormat getLocaleFormatIfCurrencyLocaleNotNull() {
Review Comment:
We could add some unit tests for this method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
