DaanHoogland commented on code in PR #8031:
URL: https://github.com/apache/cloudstack/pull/8031#discussion_r1354349206
##########
server/src/main/java/com/cloud/storage/StorageManagerImpl.java:
##########
@@ -1352,10 +1370,10 @@ public void cleanupStorage(boolean recurring) {
volService.ensureVolumeIsExpungeReady(vol.getId());
volService.expungeVolumeAsync(volumeInfo);
} else {
- s_logger.debug("Volume " + vol.getUuid() + "
is already destroyed");
+ s_logger.debug(String.format("Volume [%s] is
already destroyed.", vol.getUuid()));
}
} catch (Exception e) {
- s_logger.warn("Unable to destroy volume " +
vol.getUuid(), e);
+ s_logger.error(String.format("Unable to destroy
volume [%s] due to: [%s].", vol.getUuid(), e.getMessage()), e);
Review Comment:
```suggestion
s_logger.error(String.format("Unable to destroy
volume [%s] due to: [%s].", vol.getUuid(), e.getMessage()));
s_logger.debug(String.format("Unable to destroy
volume [%s].", vol.getUuid()), e);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
