DaanHoogland commented on code in PR #8098:
URL: https://github.com/apache/cloudstack/pull/8098#discussion_r1371393079
##########
plugins/network-elements/tungsten/src/test/java/org/apache/cloudstack/network/tungsten/service/TungstenFabricUtilsTest.java:
##########
@@ -93,13 +92,12 @@ public void sendTungstenCommandWithNullAnswer() {
@Test(expected = InvalidParameterValueException.class)
public void sendTungstenCommandWithFalseAnswer() {
TungstenProviderVO tungstenProviderVO = mock(TungstenProviderVO.class);
- TungstenAnswer tungstenAnswer = mock(TungstenAnswer.class);
+ TungstenAnswer tungstenAnswer = new
MockTungstenAnswerFactory(false).get();
TungstenCommand tungstenCommand = mock(TungstenCommand.class);
when(tungstenProviderDao.findByZoneId(anyLong())).thenReturn(tungstenProviderVO);
when(agentMgr.easySend(anyLong(),
any(TungstenCommand.class))).thenReturn(tungstenAnswer);
- when(tungstenAnswer.getResult()).thenReturn(false);
tungstenFabricUtils.sendTungstenCommand(tungstenCommand, anyLong());
}
-}
+}
Review Comment:
this looks dumb, but the lint errors are EOF without precedding EOL messages
```suggestion
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
