rg9975 commented on code in PR #7889:
URL: https://github.com/apache/cloudstack/pull/7889#discussion_r1374803966
##########
engine/storage/datamotion/src/main/java/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java:
##########
@@ -579,9 +592,10 @@ private void
handleVolumeMigrationFromManagedStorageToNonManagedStorage(VolumeIn
private void verifyFormatWithPoolType(ImageFormat imageFormat,
StoragePoolType poolType) {
if (imageFormat != ImageFormat.VHD && imageFormat != ImageFormat.OVA
&& imageFormat != ImageFormat.QCOW2 &&
- !(imageFormat == ImageFormat.RAW && StoragePoolType.PowerFlex
== poolType)) {
+ !(imageFormat == ImageFormat.RAW && (StoragePoolType.PowerFlex
== poolType ||
+ StoragePoolType.FiberChannel == poolType))) {
throw new CloudRuntimeException("Only the following image types
are currently supported: " +
- ImageFormat.VHD.toString() + ", " +
ImageFormat.OVA.toString() + ", " + ImageFormat.QCOW2.toString() + ", and " +
ImageFormat.RAW.toString() + "(for PowerFlex)");
+ ImageFormat.VHD.toString() + ", " +
ImageFormat.OVA.toString() + ", " + ImageFormat.QCOW2.toString() + ", and " +
ImageFormat.RAW.toString() + "(for PowerFlex and FiberChannel)");
Review Comment:
sure, in upcomming commit
##########
engine/storage/datamotion/src/main/java/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java:
##########
@@ -579,9 +592,10 @@ private void
handleVolumeMigrationFromManagedStorageToNonManagedStorage(VolumeIn
private void verifyFormatWithPoolType(ImageFormat imageFormat,
StoragePoolType poolType) {
if (imageFormat != ImageFormat.VHD && imageFormat != ImageFormat.OVA
&& imageFormat != ImageFormat.QCOW2 &&
- !(imageFormat == ImageFormat.RAW && StoragePoolType.PowerFlex
== poolType)) {
+ !(imageFormat == ImageFormat.RAW && (StoragePoolType.PowerFlex
== poolType ||
+ StoragePoolType.FiberChannel == poolType))) {
throw new CloudRuntimeException("Only the following image types
are currently supported: " +
- ImageFormat.VHD.toString() + ", " +
ImageFormat.OVA.toString() + ", " + ImageFormat.QCOW2.toString() + ", and " +
ImageFormat.RAW.toString() + "(for PowerFlex)");
+ ImageFormat.VHD.toString() + ", " +
ImageFormat.OVA.toString() + ", " + ImageFormat.QCOW2.toString() + ", and " +
ImageFormat.RAW.toString() + "(for PowerFlex and FiberChannel)");
Review Comment:
sure, in upcoming commit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
