Pearl1594 commented on code in PR #8100:
URL: https://github.com/apache/cloudstack/pull/8100#discussion_r1376623427
##########
plugins/network-elements/nsx/src/main/java/org/apache/cloudstack/service/NsxElement.java:
##########
@@ -293,7 +296,10 @@ public boolean implementVpc(Vpc vpc, DeployDestination
dest, ReservationContext
}
Account account = isNsxAndAccount.second();
DomainVO domain = getDomainFromAccount(account);
- return nsxService.createVpcNetwork(vpc.getZoneId(), account.getId(),
domain.getId(), vpc.getId(), vpc.getName());
+ Network.Service[] services = { Network.Service.SourceNat };
+ boolean sourceNatEnabled =
vpcOfferingServiceMapDao.areServicesSupportedByVpcOffering(vpc.getVpcOfferingId(),
services);
+ // return nsxService.createVpcNetwork(vpc.getZoneId(),
account.getId(), domain.getId(), vpc.getId(), vpc.getName(), sourceNatEnabled);
Review Comment:
clean up commented code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
