DaanHoogland commented on code in PR #7486:
URL: https://github.com/apache/cloudstack/pull/7486#discussion_r1394339714
##########
agent/src/main/java/com/cloud/agent/dao/impl/PropertiesStorage.java:
##########
@@ -92,11 +92,14 @@ public synchronized boolean configure(String name,
Map<String, Object> params) {
file = new File(path);
try {
if (!file.createNewFile()) {
- s_logger.error("Unable to create _file: " +
file.getAbsolutePath());
+ s_logger.error(String.format("Unable to create _file: %s",
file.getAbsolutePath()));
return false;
}
} catch (IOException e) {
- s_logger.error("Unable to create _file: " +
file.getAbsolutePath(), e);
+ s_logger.error(String.format("Unable to create file: %s",
file.getAbsolutePath()));
+ if (s_logger.isDebugEnabled()) {
+ s_logger.bedug(String.format("IOException while trying to
create file: %s", file.getAbsolutePath()), e);
Review Comment:
```suggestion
s_logger.debug(String.format("IOException while trying
to create file: %s", file.getAbsolutePath()), e);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
