DaanHoogland commented on code in PR #8258:
URL: https://github.com/apache/cloudstack/pull/8258#discussion_r1403232717
##########
ui/src/views/network/AclListRulesTab.vue:
##########
@@ -334,7 +334,17 @@ export default {
result += columnDelimiter
}
- result += typeof item[key] === 'string' &&
item[key].includes(columnDelimiter) ? `"${item[key]}"` : item[key]
+ if (key === 'tags') {
+ var tags = '"'
+ if (item[key].length > 0) {
+ item[key].forEach(tag => {
+ tags += '(' + tag.key + ',' + tag.value + ')'
Review Comment:
ok, should we include double quotes around the keys and values or add
escapes. This si really new functionality so we can make choices here.
Honestly, I think this si good as a first implementation and we should think
about adding options like
- export as json
- do escaping
- use sinlge or double quotes
cc @shwstppr
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
