winterhazel opened a new pull request, #8339: URL: https://github.com/apache/cloudstack/pull/8339
### Description When a public IP gets removed from quarantine, the removal reason gets saved to the database; however, it may also be useful for operators to know who removed the public IP from quarantine. For that reason, this PR extends the public IP quarantine feature so that the account that deliberately removed a IP from quarantine also gets saved to the database. ### Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [ ] Bug fix (non-breaking change which fixes an issue) - [X] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) ### Feature/Enhancement Scale or Bug Severity #### Feature/Enhancement Scale - [ ] Major - [X] Minor ### How Has This Been Tested? 1. I set the configuration `public.ip.address.quarantine.duration` to 60 minutes; 2. Through CloudMonkey, I logged into the domain admin account `A`, acquired an IP and released it. Then, I called `removeQuarantinedIp` to remove the IP from quarantine. Finally, I called `listQuarantinedIps` with `showremoved=true` and verified that the field `removeraccountid` in the corresponding quarantine entry contained `A`'s uuid; 3. Through CloudMonkey, I logged into account `A`, acquired an IP and released it. Then, I logged into the root admin account and called `removeQuarantinedIp` to remove the IP from quarantine. Finally, I called `listQuarantinedIps` with `showremoved=true` and verified that the field `removeraccountid` in the corresponding quarantine entry contained the root admin's uuid. 4. In account `A`, I acquired a public IP, released it and acquired it again. I verified through `listQuarantinedIps` that the field `removeraccountid` in the corresponding entry contained `A`'s uuid. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
