winterhazel commented on PR #8070: URL: https://github.com/apache/cloudstack/pull/8070#issuecomment-1850715148
@harikrishna-patnala thanks for testing. Regarding issue 3, when running the UI locally, `overridediskofferingid` will be set to the selected disk offering's id in step 2; even if you disable the override, it will still have the id of the selected disk offering, but it will get set back to the id of the the selected compute offering's disk offering if you interact with the deployment form. You should be able to reproduce issue 3 the following ways: (i) by using a compute offering that does not have an associated disk offering. 1. Select the compute offering Small Instance; 2. Enable root disk offering override; 3. Select the disk offering testDO2; 4. Disable the override. Here you can interact with the rest of the page and the root disk offering will still get overridden; 5. Deploy a VM by clicking the launch instance button. (ii) by not interacting with anything other than the launch instance button after disabling the override. 1. Select the compute offering testCO1; 2. Enable root disk offering override; 3. Select the disk offering testDO2; 4. Disable the override. Do not interact with the deployment form after disabling it; 5. Deploy a VM by clicking the launch instance button. Before the fix, the deployed VM's volume will be created using testDO2. > @winterhazel also can you please change the base branch to 4.18 as I can see this issue in 4.18 as well. Sure, I'll change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
