DaanHoogland commented on code in PR #8316:
URL: https://github.com/apache/cloudstack/pull/8316#discussion_r1429792084
##########
server/src/main/java/com/cloud/network/security/SecurityGroupManagerImpl.java:
##########
@@ -1410,7 +1407,7 @@ public SecurityGroupVO getDefaultSecurityGroup(long
accountId) {
}
@Override
- public SecurityGroup getSecurityGroup(String name, long accountId) {
+ public SecurityGroupVO getSecurityGroup(String name, long accountId) {
Review Comment:
@weizhouapache, would it be better to still return `SecurityGroup` in the
calling method and maybe add methods to the interface? We are adding coupling
this way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
