DaanHoogland commented on PR #8370:
URL: https://github.com/apache/cloudstack/pull/8370#issuecomment-1862731148
> > @JoaoJandre can checks be skipped if source is User.Source.LDAP ?
>
> I'd rather keep the feature agnostic and avoid adding different workflows.
If the consensus is that changing the configuration value is not the best
solution, I'd rather either document the behavior, or change the call on
`org.apache.cloudstack.ldap.LdapAuthenticator#authenticate()` to something that
is not a blank string.
I agree, certainly if the LDAP autentication is the only one that suffers. I
do not remember exactly how this works, but LDAP should put its own
requirements on passwords.
see my dumb comment there ;)
```
// TODO not allowing an empty password is a policy we shouldn't
decide on. A private cloud may well want to allow this.
if (StringUtils.isNoneEmpty(username, password)) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
