winterhazel commented on PR #8337: URL: https://github.com/apache/cloudstack/pull/8337#issuecomment-1892520446
@DaanHoogland thanks for testing, but ideally this is not enough regarding the changes in `AutogenView.vue`. There are different ways in which labels are shown and provided to confirmation dialogs, and this only tests some of these. As all of the existing ways have been affected, I would appreciate if we validated that all of them are still working as before (and therefore, that every dialog is still being shown as expected). Here is everything that has been affected and how it can be validated below: 1. How the `message` can be presented: a. When bulk deleting/powering off a resource (line 186) b. When bulk doing something other than deleting/powering off a resource (line 192) c. Every other situation (line 199) 2. How `message`s can be inserted into actions: a. Providing just a label; b. Providing a function that returns a label; c. Providing a function that returns an array. 3. How `successMessage`s can be inserted into actions: a. Providing just a label; b. Providing a function that returns a label; c. Providing a function that returns an array; d. Not providing anything (a generic success message is used). 4. Providing a label in the `additionalMessage` param. Please feel free to point if I missed something. Here's how to test all these things: 1. Bulk deleting some VMs. This tests 1a and 2a. 2. Bulk restarting some networks. This tests 1b. 3. Archiving an event. This tests 1c and 3a. 4. Locking a user. This tests 2c and 3c. 5. Disabling a user's 2FA. This tests 2b and 3d. 6. The `additionalMessage` is only used when updating a VMware data center. If an environment with VMware is unavailable, an option to test it is by just inserting the `additionalMessage` param into any action. This tests 4. 7. 3b is not used anywhere, so we can just change any existing `successMessage` into a function that returns a label and verify it is working. I have tested all of those and verified they are still working as expected, but I would appreciate if someone else could also verify them. --- Also pinging @JoaoJandre @shwstppr. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
