sureshanaparti commented on code in PR #8547:
URL: https://github.com/apache/cloudstack/pull/8547#discussion_r1463275271
##########
engine/storage/volume/src/main/java/org/apache/cloudstack/storage/datastore/provider/DefaultHostListener.java:
##########
@@ -55,8 +57,12 @@
import javax.inject.Inject;
import java.util.List;
-public class DefaultHostListener implements HypervisorHostListener {
+public class DefaultHostListener implements HypervisorHostListener,
Configurable {
private static final Logger s_logger =
Logger.getLogger(DefaultHostListener.class);
+ ConfigKey<Integer> ModifyStoragePoolCommandWait = new
ConfigKey<Integer>("Advanced", Integer.class,
+ "modify.storage.pool.command.wait", "60",
+ "Time in seconds to wait for ModifyStoragePoolCommand command to
return", true);
Review Comment:
CS have lot of such cmds, maybe not good idea to add a config at cmd level.
(later, might end up one config for each cmd). generic configs, eg.
storage.command.wait / host.command.wait, based on the category with
appropriate descriptions might be good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
